Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(config): adjust schema for documentation website, closes #4139 #4142

Merged
merged 12 commits into from
May 17, 2022
Merged

feat(config): adjust schema for documentation website, closes #4139 #4142

merged 12 commits into from
May 17, 2022

Conversation

lucasfernog
Copy link
Member

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Docs
  • New Binding issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes, and the changes were approved in issue #___
  • No

Checklist

  • When resolving issues, they are referenced in the PR's title (e.g fix: remove a typo, closes #___, #___)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.
  • I have added a convincing reason for adding this feature, if necessary

Other information

@lucasfernog lucasfernog requested a review from a team May 16, 2022 13:11
lorenzolewis
lorenzolewis requested changes May 16, 2022
View reviewed changes
core/tauri-utils/src/config.rs Outdated Show resolved Hide resolved
tooling/cli/schema.json Outdated Show resolved Hide resolved
lorenzolewis
lorenzolewis previously approved these changes May 16, 2022
View reviewed changes
@lorenzolewis
Copy link
Member

Looks good to me now

@lucasfernog lucasfernog requested a review from a team May 16, 2022 16:13
@lucasfernog lucasfernog requested a review from a team as a code owner May 16, 2022 16:13
@lucasfernog lucasfernog merged commit 29d8e76 into dev May 17, 2022
@lucasfernog lucasfernog deleted the feat/config branch May 17, 2022 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FabianLars FabianLars FabianLars left review comments

@lorenzolewis lorenzolewis lorenzolewis left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@lucasfernog @lorenzolewis @FabianLars