Skip to content

fix(core): fileDropEnabled option is not working when creating a new WebviewWindow#4146

Merged
lucasfernog merged 1 commit intotauri-apps:devfrom
TomScavo:dev
May 17, 2022
Merged

fix(core): fileDropEnabled option is not working when creating a new WebviewWindow#4146
lucasfernog merged 1 commit intotauri-apps:devfrom
TomScavo:dev

Conversation

@TomScavo
Copy link
Copy Markdown
Contributor

@TomScavo TomScavo commented May 17, 2022 •
edited
Loading

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Docs
  • New Binding issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes, and the changes were approved in issue #___
  • No

Checklist

  • When resolving issues, they are referenced in the PR's title (e.g fix: remove a typo, closes #___, #___)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.
  • I have added a convincing reason for adding this feature, if necessary

Other information

@TomScavo TomScavo requested a review from a team May 17, 2022 06:19
@TomScavo TomScavo requested a review from a team as a code owner May 17, 2022 06:19
@TomScavo TomScavo changed the title fix(core): fileDropEnabled option is not working when creating a new … fix(core): fileDropEnabled option is not working when creating a new WebviewWindow May 17, 2022
lucasfernog
lucasfernog approved these changes May 17, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@lucasfernog lucasfernog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch, thanks!

@lucasfernog lucasfernog merged commit 706fcbd into tauri-apps:dev May 17, 2022
@rming rming mentioned this pull request May 19, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lucasfernog lucasfernog lucasfernog approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@TomScavo @lucasfernog