refactor: simplify api.js bundling - #4277
Merged
Merged
Conversation
amrbashir
marked this pull request as draft
June 5, 2022 11:23
amrbashir
marked this pull request as ready for review
June 5, 2022 12:16
Member
|
We need to test this on Webpack and CRA. #2360 (comment) |
Member
Author
|
The |
Member
Author
|
CRA template created with |
imranbarbhuiya
suggested changes
Jul 10, 2022
| import * as tauri from './tauri' | ||
| import * as updater from './updater' | ||
| import * as window from './window' | ||
| import * as os from './os' |
Member
There was a problem hiding this comment.
This bothers me because it's the only non-alphabetised one on the list ;)
Member
Author
There was a problem hiding this comment.
I will fix that once we are ready to merge this PR
lucasfernog
reviewed
Sep 28, 2022
| }, | ||
| "engines": { | ||
| "node": ">= 12.22.0", | ||
| "node": ">= 14.6.0", |
Member
There was a problem hiding this comment.
do we really need to bump this? if so we need to add it to the changelog
Member
Author
There was a problem hiding this comment.
node 12 has reached end of life 5 months ago
lucasfernog
approved these changes
Oct 4, 2022
lucasfernog
left a comment
lucasfernog
left a comment
Member
There was a problem hiding this comment.
Let's keep an eye to see if this doen't break any app, I've tested it on Quasar and CRA
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Does this PR introduce a breaking change?
Checklist
fix: remove a typo, closes #___, #___)Other information