Skip to content

refactor(core): use Icon for tray icons#4342

Merged
lucasfernog merged 6 commits intodevfrom
refactor/tray-icons
Jun 14, 2022
Merged

refactor(core): use Icon for tray icons#4342
lucasfernog merged 6 commits intodevfrom
refactor/tray-icons

Conversation

@lucasfernog
Copy link
Member

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Docs
  • New Binding issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes, and the changes were approved in issue #___
  • No

Checklist

  • When resolving issues, they are referenced in the PR's title (e.g fix: remove a typo, closes #___, #___)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.
  • I have added a convincing reason for adding this feature, if necessary

Other information

@lucasfernog lucasfernog requested review from a team June 14, 2022 19:40
@lucasfernog lucasfernog requested a review from a team as a code owner June 14, 2022 19:40
@amrbashir
Copy link
Member

IconDto in endpoints/window.rs also need to be updated.

@lucasfernog
Copy link
Member Author

why? I already changed the type and nothing else changed @amrbashir

@amrbashir
Copy link
Member

TrayIcon enum that had File and Raw variant removed, thought the js API too will remove it?

@lucasfernog
Copy link
Member Author

TrayIcon enum that had File and Raw variant removed, thought the js API too will remove it?

We also had those variants for window icons, at runtime we read the icon and get a rgba vec to use on tao.

@lucasfernog lucasfernog merged commit 4ce8e22 into dev Jun 14, 2022
@lucasfernog lucasfernog deleted the refactor/tray-icons branch June 14, 2022 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants