Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: assert config.bundle.identifier to be only alphanumeric, hyphens or dots. closes #4359 #4363

Merged
merged 3 commits into from
Jun 17, 2022

Conversation

imadbz
Copy link
Contributor

@imadbz imadbz commented Jun 16, 2022

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Docs
  • New Binding issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes, and the changes were approved in issue #___
  • No

Checklist

  • When resolving issues, they are referenced in the PR's title (e.g fix: remove a typo, closes #___, #___)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.
  • I have added a convincing reason for adding this feature, if necessary

Other information

@imadbz imadbz requested a review from a team June 16, 2022 08:42
@imadbz
Copy link
Contributor Author

imadbz commented Jun 16, 2022

closes #4359

@imadbz
Copy link
Contributor Author

imadbz commented Jun 16, 2022

I also updated documentation in this pull request: tauri-apps/tauri-docs#659

should be approved together.

@FabianLars
Copy link
Member

Just for visibility i copy-paste my comment from the tauri-docs pr:

The config docs for the website are auto generated from the tauri repo.
This https://github.com/tauri-apps/tauri/blob/dev/core/tauri-utils/src/config.rs is the main file. Building the cli in the tauri repo then regenerates this file https://github.com/tauri-apps/tauri/blob/dev/tooling/cli/schema.json (For this kinda change manually changing both should be fine).

@imadbz
Copy link
Contributor Author

imadbz commented Jun 16, 2022

ok! updated docs on main repo too

@imadbz imadbz requested a review from a team as a code owner June 17, 2022 13:22
@lucasfernog lucasfernog merged commit 0674a80 into tauri-apps:dev Jun 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants