feat(bundler/msi): add perMachine option, disabled by default, closes #2319
#4509
Conversation
| --- | ||
|
|
||
| Added `perMachine` option to `tauri.conf.json > tauri > bundle > windows > wix`, disabled by default. | ||
| **Breaking change** `msi` installer will install your app per-user by default now. |
There was a problem hiding this comment.
not really a breaking change right?
There was a problem hiding this comment.
It is a slight breaking change, that's why I kept the bump as patch (still considering to change it to minor).
Apps that relied heavily on being installed perMachine won't work unless they specify perMachine. I don't have an example at the top of my head but I thought I'd be cautious and treat it as breaking.
There was a problem hiding this comment.
doesn't it make more sense to keep it enabled by default then?
Edit: Actually i think i prefer perUser being the default, nvm me
There was a problem hiding this comment.
I prefer perUser as default but if it can break any kind of app, we need to keep the per machine as default.
There was a problem hiding this comment.
it has a slight chance to break some apps but I think perUser should be the default, even if it means this PR shouldn't be merged in v1
There was a problem hiding this comment.
even tho i can't think of anything really where changing it to perUser would break anything, but what about merging this pr with perMachine as default and changing the default with v2?
Edit: Okay it can break if the user selects a folder like Program Files, because it doesn't request permissions on demand (is that even possible?)
There was a problem hiding this comment.
I have to move my glow stick for you guys.
I think this is a very important function and it will be very helpul if it can be merged and published as soon as possible.
|
Only tested with |
What kind of change does this PR introduce?
Does this PR introduce a breaking change?
Checklist
fix: remove a typo, closes #___, #___)Other information