Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(cli): prompt for before*Command, closes #4691 #4721

Merged
merged 3 commits into from
Jul 25, 2022
Merged

feat(cli): prompt for before*Command, closes #4691 #4721

merged 3 commits into from
Jul 25, 2022

Conversation

amrbashir
Copy link
Member

@amrbashir amrbashir commented Jul 20, 2022 •
edited
Loading

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Docs
  • New Binding issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes, and the changes were approved in issue #___
  • No

Checklist

  • When resolving issues, they are referenced in the PR's title (e.g fix: remove a typo, closes #___, #___)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.
  • I have added a convincing reason for adding this feature, if necessary

Other information

@amrbashir amrbashir requested a review from a team as a code owner July 20, 2022 13:33
amrbashir
amrbashir commented Jul 20, 2022
View reviewed changes
.changes/cli-init-before-commands.md
Comment on lines +2 to +3
"cli.rs": "minor"
"cli.js": "minor"
Copy link
Member Author

@amrbashir amrbashir Jul 20, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if we are now using minor for new features

@lucasfernog lucasfernog merged commit 6d4945c into dev Jul 25, 2022
@lucasfernog lucasfernog deleted the init-before-commands branch July 25, 2022 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucasfernog lucasfernog lucasfernog approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@amrbashir @lucasfernog