Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add libc field to node packages #4856

Merged
merged 2 commits into from
Aug 4, 2022

Conversation

paul-soporan
Copy link
Contributor

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Docs
  • New Binding issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

This PR adds a libc field to the relevant Node packages.

Originally introduced by Yarn 3.2 (yarnpkg/berry#3981), the field is the equivalent of os / cpu but for libc (currently supports glibc & musl). It allows package managers to skip installing packages with incompatible libcs.

It has since been implemented in pnpm (pnpm/pnpm#4454) and cnpm (cnpm/npminstall#387), and npm has plans to implement it too (npm/rfcs#438).

Does this PR introduce a breaking change?

  • Yes, and the changes were approved in issue #___
  • No

Checklist

  • When resolving issues, they are referenced in the PR's title (e.g fix: remove a typo, closes #___, #___)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.
  • I have added a convincing reason for adding this feature, if necessary

Other information

@paul-soporan paul-soporan requested a review from a team as a code owner August 4, 2022 01:07
Copy link
Member

@lucasfernog lucasfernog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing, thank you!

@lucasfernog lucasfernog merged commit f7d2dfc into tauri-apps:dev Aug 4, 2022
@paul-soporan paul-soporan deleted the chore/libc branch August 4, 2022 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants