Skip to content

expose set_device_event_filter in tauri#5562

Merged
lucasfernog merged 9 commits intotauri-apps:devfrom
cymruu:cymruu/expose-set_device_event_filter-in-tauri
Dec 13, 2022
Merged

expose set_device_event_filter in tauri#5562
lucasfernog merged 9 commits intotauri-apps:devfrom
cymruu:cymruu/expose-set_device_event_filter-in-tauri

Conversation

@cymruu
Copy link
Contributor

@cymruu cymruu commented Nov 6, 2022

Closes #5496

What kind of change does this PR introduce?

Does this PR introduce a breaking change?

  • Yes, and the changes were approved in issue #___
  • No

Checklist

  • When resolving issues, they are referenced in the PR's title (e.g fix: remove a typo, closes #___, #___)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.
  • I have added a convincing reason for adding this feature, if necessary

Other information

@cymruu cymruu requested a review from a team as a code owner November 6, 2022 20:53
@cymruu cymruu marked this pull request as draft November 6, 2022 20:53
@cymruu cymruu force-pushed the cymruu/expose-set_device_event_filter-in-tauri branch from d37d075 to fbd6653 Compare November 7, 2022 23:03
@cymruu cymruu force-pushed the cymruu/expose-set_device_event_filter-in-tauri branch from fbd6653 to 814d4b9 Compare November 7, 2022 23:13
@cymruu cymruu marked this pull request as ready for review November 7, 2022 23:20
@WSH032
Copy link
Contributor

WSH032 commented Aug 15, 2025

Hi, is there any particular reason why set_device_event_filter is only implemented for App and not for AppHandle?

I just browsed the code, and it seems possible to implement it for AppHandle as well. Is it because this method must be called before App::run to be effective? Or was it just overlooked at the time?

I'd like to submit a PR to implement this, unless there's a specific reason not to.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[feat] Expose set_device_event_filter to Tauri API

3 participants