feat: add is_minimized (fix #3878)#5618
Merged
lucasfernog merged 10 commits intotauri-apps:devfrom Dec 12, 2022
Merged
Conversation
amrbashir
requested changes
Nov 14, 2022
Member
amrbashir
left a comment
amrbashir
left a comment
There was a problem hiding this comment.
Can you also add the same method to the JS API in tooling/api/src/window.ts?
amrbashir
requested changes
Nov 16, 2022
Co-authored-by: Amr Bashir <amr.bashir2015@gmail.com>
Co-authored-by: Amr Bashir <amr.bashir2015@gmail.com>
amrbashir
requested changes
Dec 12, 2022
Member
amrbashir
left a comment
amrbashir
left a comment
There was a problem hiding this comment.
LGTM! but you also need to rebuild core/tauri/scripts/bundle.global.js, just run yarn build inside tooling/api and commit the changes
cymruu
pushed a commit
to cymruu/tauri
that referenced
this pull request
Dec 13, 2022
Co-authored-by: Amr Bashir <amr.bashir2015@gmail.com> Co-authored-by: Lucas Nogueira <lucas@tauri.studio> fixes tauri-apps#3878
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Does this PR introduce a breaking change?
Checklist
fix: remove a typo, closes #___, #___)Other information
This PR implements
is_minimized()and fixes #3878.