Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add is_minimized (fix #3878) #5618

Merged
merged 10 commits into from
Dec 12, 2022
Merged

feat: add is_minimized (fix #3878) #5618

merged 10 commits into from
Dec 12, 2022

Conversation

crpz1
Copy link
Contributor

@crpz1 crpz1 commented Nov 13, 2022

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Docs
  • New Binding issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes, and the changes were approved in issue #___
  • No

Checklist

  • When resolving issues, they are referenced in the PR's title (e.g fix: remove a typo, closes #___, #___)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.
  • I have added a convincing reason for adding this feature, if necessary

Other information

This PR implements is_minimized() and fixes #3878.

@crpz1 crpz1 requested a review from a team as a code owner November 13, 2022 10:55
amrbashir
amrbashir requested changes Nov 14, 2022
View reviewed changes
Copy link
Member

@amrbashir amrbashir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also add the same method to the JS API in tooling/api/src/window.ts?

amrbashir
amrbashir requested changes Nov 16, 2022
View reviewed changes
.changes/is-minimized.md Outdated Show resolved Hide resolved
tooling/api/src/window.ts Outdated Show resolved Hide resolved
tooling/api/src/window.ts Show resolved Hide resolved
crpz1 and others added 3 commits November 16, 2022 22:36
@crpz1
implement in window.rs
a88ee10
@crpz1 @amrbashir
Update .changes/is-minimized.md
f03e0de 
Co-authored-by: Amr Bashir <amr.bashir2015@gmail.com>
@crpz1 @amrbashir
Update tooling/api/src/window.ts
c361c38 
Co-authored-by: Amr Bashir <amr.bashir2015@gmail.com>
@crpz1 crpz1 requested a review from amrbashir December 12, 2022 04:05
amrbashir
amrbashir requested changes Dec 12, 2022
View reviewed changes
Copy link
Member

@amrbashir amrbashir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! but you also need to rebuild core/tauri/scripts/bundle.global.js, just run yarn build inside tooling/api and commit the changes

@lucasfernog lucasfernog merged commit 62144ef into tauri-apps:dev Dec 12, 2022
cymruu pushed a commit to cymruu/tauri that referenced this pull request Dec 13, 2022
@crpz1 @cymruu
feat: add is_minimized (fix tauri-apps#3878) (tauri-apps#5618)
58edb02 
Co-authored-by: Amr Bashir <amr.bashir2015@gmail.com>
Co-authored-by: Lucas Nogueira <lucas@tauri.studio>
fixes tauri-apps#3878
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amrbashir amrbashir amrbashir requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[feat] Add window.is_minimized()
3 participants
@crpz1 @amrbashir @lucasfernog