Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(cli.rs): improve rustc not found error msg #6021

Merged
merged 1 commit into from
Jan 17, 2023
Merged

fix(cli.rs): improve rustc not found error msg #6021

merged 1 commit into from
Jan 17, 2023

Conversation

amrbashir
Copy link
Member

@amrbashir amrbashir commented Jan 9, 2023 •
edited
Loading

ref: #6014

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Docs
  • New Binding issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes, and the changes were approved in issue #___
  • No

Checklist

  • When resolving issues, they are referenced in the PR's title (e.g fix: remove a typo, closes #___, #___)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.
  • I have added a convincing reason for adding this feature, if necessary

Other information

@amrbashir amrbashir requested a review from a team as a code owner January 9, 2023 12:34
FabianLars
FabianLars approved these changes Jan 9, 2023
View reviewed changes
Copy link
Member

@FabianLars FabianLars left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That one was weirdly popular the last 1 or 2 weeks for some reason.

@lucasfernog lucasfernog merged commit 7aab3e2 into dev Jan 17, 2023
@lucasfernog lucasfernog deleted the fix/cli/rustc-not-found branch January 17, 2023 01:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucasfernog lucasfernog lucasfernog approved these changes

@FabianLars FabianLars FabianLars approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@amrbashir @lucasfernog @FabianLars