fix(cli.js): detect node-<version> binary, closes #6427#6432
fix(cli.js): detect node-<version> binary, closes #6427#6432lucasfernog merged 2 commits intodevfrom
node-<version> binary, closes #6427#6432Conversation
|
I'm having the same issue and was about to make my own PR. I've noticed an issue in the new regex proposed: In regex, the hyphen is a special character and should ideally be escaped with a slash to prevent any errors. It is also important to consider the use of the asterisk character (marches 0 or more) over the question mark character (matches 0 or 1) since it would be unlikely for a node binary name to have more than one hyphen unless there is a good reson to. I propose that the regex be changed to this instead: |
hyphen is only special if it appears inside a range like
Right, |
Co-authored-by: TurtleIdiot <18502738+TurtleIdiot@users.noreply.github.com>
What kind of change does this PR introduce?
Does this PR introduce a breaking change?
Checklist
fix: remove a typo, closes #___, #___)Other information