Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cli.js): detect node-<version> binary, closes #6427 #6432

Merged
merged 2 commits into from
Mar 16, 2023

Conversation

amrbashir
Copy link
Member

@amrbashir amrbashir commented Mar 13, 2023

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Docs
  • New Binding issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes, and the changes were approved in issue #___
  • No

Checklist

  • When resolving issues, they are referenced in the PR's title (e.g fix: remove a typo, closes #___, #___)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.
  • I have added a convincing reason for adding this feature, if necessary

Other information

@amrbashir amrbashir requested a review from a team as a code owner March 13, 2023 00:20
@TurtleIdiot
Copy link
Contributor

I'm having the same issue and was about to make my own PR.

I've noticed an issue in the new regex proposed: /(nodejs|node)-*([1-9]*)*$/g

In regex, the hyphen is a special character and should ideally be escaped with a slash to prevent any errors. It is also important to consider the use of the asterisk character (marches 0 or more) over the question mark character (matches 0 or 1) since it would be unlikely for a node binary name to have more than one hyphen unless there is a good reson to.

I propose that the regex be changed to this instead:
/(nodejs|node)\-?([1-9]*)*$/g

@amrbashir
Copy link
Member Author

In regex, the hyphen is a special character and should ideally be escaped with a slash to prevent any errors

hyphen is only special if it appears inside a range like [a-z], but won't hurt to escape it.

It is also important to consider the use of the asterisk character (marches 0 or more) over the question mark character (matches 0 or 1) since it would be unlikely for a node binary name to have more than one hyphen unless there is a good reson to.

Right, ? is better here, I will update it.

Co-authored-by: TurtleIdiot <18502738+TurtleIdiot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants