Skip to content

fix(cli): only add -- to generated android template for npm#6508

Merged
lucasfernog merged 1 commit intonextfrom
fix/cli/only-npm-extra-dash
Mar 21, 2023
Merged

fix(cli): only add -- to generated android template for npm#6508
lucasfernog merged 1 commit intonextfrom
fix/cli/only-npm-extra-dash

Conversation

@amrbashir
Copy link
Copy Markdown
Member

@amrbashir amrbashir commented Mar 20, 2023 •
edited
Loading

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Docs
  • New Binding issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes, and the changes were approved in issue #___
  • No

Checklist

  • When resolving issues, they are referenced in the PR's title (e.g fix: remove a typo, closes #___, #___)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.
  • I have added a convincing reason for adding this feature, if necessary

Other information

@amrbashir amrbashir requested a review from a team as a code owner March 20, 2023 23:09
@lucasfernog lucasfernog merged commit c787f74 into next Mar 21, 2023
@lucasfernog lucasfernog deleted the fix/cli/only-npm-extra-dash branch March 21, 2023 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lucasfernog lucasfernog lucasfernog approved these changes

Assignees

No one assigned

Labels

None yet

Projects

Roadmap
Status: ✅ Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@amrbashir @lucasfernog