Skip to content

fix: only build specified rust targets for aab/apk build#6625

Merged
lucasfernog merged 7 commits intonextfrom
fix/apk+aab/build-specified-rust-only
Apr 5, 2023
Merged

fix: only build specified rust targets for aab/apk build#6625
lucasfernog merged 7 commits intonextfrom
fix/apk+aab/build-specified-rust-only

Conversation

@amrbashir
Copy link
Member

@amrbashir amrbashir commented Apr 4, 2023

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Docs
  • New Binding issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes, and the changes were approved in issue #___
  • No

Checklist

  • When resolving issues, they are referenced in the PR's title (e.g fix: remove a typo, closes #___, #___)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.
  • I have added a convincing reason for adding this feature, if necessary

Other information

@amrbashir amrbashir requested a review from a team as a code owner April 4, 2023 00:17
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When I run without the --target argument the CLI is only building aarch64 and x86_64 targets. I switched back to the next branch and it built armv7 and i686 correctly.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will look into it now

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be fine now but needs tauri-apps/cargo-mobile2#129

lucasfernog
lucasfernog previously approved these changes Apr 5, 2023
@lucasfernog lucasfernog merged commit d03e47d into next Apr 5, 2023
@lucasfernog lucasfernog deleted the fix/apk+aab/build-specified-rust-only branch April 5, 2023 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants

Comments