fix: only build specified rust targets for aab/apk build #6625
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucasfernog
reviewed
Apr 4, 2023
| @@ -21,6 +21,11 @@ open class RustPlugin : Plugin<Project> { | |||
| override fun apply(project: Project) { | |||
| config = project.extensions.create("rust", Config::class.java) | |||
| project.afterEvaluate { | |||
| val abiList = (findProperty("abiList") as? String)?.split(",")?.map { it.trim() } ?: listOf( | |||
There was a problem hiding this comment.
When I run without the --target argument the CLI is only building aarch64 and x86_64 targets. I switched back to the next branch and it built armv7 and i686 correctly.
There was a problem hiding this comment.
I will look into it now
There was a problem hiding this comment.
should be fine now but needs tauri-apps/cargo-mobile2#129
…b.com/tauri-apps/tauri into fix/apk+aab/build-specified-rust-only
lucasfernog
previously approved these changes
Apr 5, 2023
lucasfernog
approved these changes
Apr 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Does this PR introduce a breaking change?
Checklist
fix: remove a typo, closes #___, #___)Other information