Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(cli): add --release for android dev #6638

Merged
merged 4 commits into from
Apr 5, 2023
Merged

feat(cli): add --release for android dev #6638

merged 4 commits into from
Apr 5, 2023

Conversation

amrbashir
Copy link
Member

@amrbashir amrbashir commented Apr 5, 2023 •
edited
Loading

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Docs
  • New Binding issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes, and the changes were approved in issue #___
  • No

Checklist

  • When resolving issues, they are referenced in the PR's title (e.g fix: remove a typo, closes #___, #___)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.
  • I have added a convincing reason for adding this feature, if necessary

Other information

@amrbashir amrbashir requested a review from a team as a code owner April 5, 2023 00:16
@amrbashir amrbashir linked an issue Apr 5, 2023 that may be closed by this pull request
[bug] window.__TAURI_IPC__ is not a function when not using a dev server #6594
Closed
@lucasfernog lucasfernog changed the title feat(cli): add --release for android dev, closes #6594 feat(cli): add --release for android dev Apr 5, 2023
@lucasfernog lucasfernog merged commit 63f088e into next Apr 5, 2023
@lucasfernog lucasfernog deleted the feat/cli/android/dev-release branch April 5, 2023 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucasfernog lucasfernog lucasfernog approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Roadmap
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[bug] window.__TAURI_IPC__ is not a function when not using a dev server
2 participants
@amrbashir @lucasfernog