Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(bundler/NSIS): allow specifying custom lang files #6867

Merged
merged 7 commits into from
May 15, 2023
Merged

feat(bundler/NSIS): allow specifying custom lang files #6867

merged 7 commits into from
May 15, 2023

Conversation

amrbashir
Copy link
Member

@amrbashir amrbashir commented May 5, 2023 •
edited
Loading

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Docs
  • New Binding issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes, and the changes were approved in issue #___
  • No

Checklist

  • When resolving issues, they are referenced in the PR's title (e.g fix: remove a typo, closes #___, #___)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.
  • I have added a convincing reason for adding this feature, if necessary

Other information

@amrbashir amrbashir requested a review from a team as a code owner May 5, 2023 01:22
FabianLars
FabianLars reviewed May 5, 2023
View reviewed changes
tooling/bundler/src/bundle/windows/nsis.rs Outdated Show resolved Hide resolved
core/tauri-utils/src/config.rs Outdated Show resolved Hide resolved
amrbashir and others added 2 commits May 5, 2023 14:56
@amrbashir @FabianLars
Update tooling/bundler/src/bundle/windows/nsis.rs
477a317 
Co-authored-by: Fabian-Lars <fabianlars@fabianlars.de>
@amrbashir @FabianLars
Update core/tauri-utils/src/config.rs
4432514 
Co-authored-by: Fabian-Lars <fabianlars@fabianlars.de>
@FabianLars
Copy link
Member

(you need to rebuild the scheme after that one suggestion btw. oh and maybe copy the change to settings.rs too)

lucasfernog
lucasfernog previously approved these changes May 14, 2023
View reviewed changes
@amrbashir amrbashir merged commit 2948820 into dev May 15, 2023
36 checks passed
@amrbashir amrbashir deleted the feat/nsis/custom-lang-files branch May 15, 2023 15:11
@wusyong wusyong added the security: needs audit This issue/PR needs a security audit label May 25, 2023
@chippers chippers added security: reviewed This issue/PR has been review by wg-security and removed security: needs audit This issue/PR needs a security audit labels Jun 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FabianLars FabianLars FabianLars left review comments

@lucasfernog lucasfernog lucasfernog approved these changes

Assignees
No one assigned
Labels
security: reviewed This issue/PR has been review by wg-security
Projects
Roadmap
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@amrbashir @FabianLars @lucasfernog @chippers @wusyong