Skip to content

feat: add notification sound#7269

Merged
lucasfernog merged 15 commits into1.xfrom
feat/notification-sound
Aug 8, 2023
Merged

feat: add notification sound#7269
lucasfernog merged 15 commits into1.xfrom
feat/notification-sound

Conversation

@amrbashir
Copy link
Member

@amrbashir amrbashir commented Jun 20, 2023

ref: #7210

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Docs
  • New Binding issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes, and the changes were approved in issue #___
  • No

Checklist

  • When resolving issues, they are referenced in the PR's title (e.g fix: remove a typo, closes #___, #___)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.
  • I have added a convincing reason for adding this feature, if necessary

Other information

@amrbashir amrbashir requested a review from a team as a code owner June 20, 2023 13:56
@amrbashir amrbashir force-pushed the feat/notification-sound branch from 14352a8 to 3b59795 Compare June 20, 2023 14:00
amrbashir and others added 3 commits June 21, 2023 00:25
Co-authored-by: Lucas Fernandes Nogueira <lucas@tauri.studio>
Co-authored-by: Lucas Fernandes Nogueira <lucas@tauri.studio>
@lucasfernog
Copy link
Member

@amrbashir I've pushed a change to read NSUserNotificationDefaultSoundName but https://github.com/h4llow3En/mac-notification-sys/blob/7ab3864527698472224671093e581d4d1880851f/src/notification.rs#LL339C54-L339C54 doesn't really let us play it (or any custom sound defined in the app bundle).

@amrbashir
Copy link
Member Author

Yeah, looks like we need to open a PR upstream

@lucasfernog lucasfernog merged commit 6c408b7 into 1.x Aug 8, 2023
@lucasfernog lucasfernog deleted the feat/notification-sound branch August 8, 2023 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: 🔎 In audit

Development

Successfully merging this pull request may close these issues.

2 participants