Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remove master branch, switch to git merge --ff-only #744

Merged
merged 2 commits into from
Jul 5, 2020

Conversation

jbolda
Copy link
Member

@jbolda jbolda commented Jul 4, 2020

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • New Binding Issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes. Issue #___
  • No

The PR fulfills these requirements:

  • It's submitted to the dev branch and not the master branch
  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix: #xxx[,#xxx], where "xxx" is the issue number)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:
I believe git merge sha --ff-only should work fine with how we use it. Any git aficionados know with more certainty?

@jbolda jbolda requested a review from a team as a code owner July 4, 2020 04:09
@jbolda jbolda requested a review from a team July 4, 2020 04:09
Copy link
Member

@rajivshah3 rajivshah3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.github/workflows/pr-to-master.yml should probably be renamed to pr-to-latest as well

@jbolda jbolda merged commit 92fc379 into dev Jul 5, 2020
@jbolda jbolda deleted the feat/remove-master-branch branch July 5, 2020 23:00
lucasfernog added a commit that referenced this pull request Jul 8, 2020
* fix: update rust docs PR needs a path (#742)

It is being checked out in a subdir, so we need to give the PR a path to it.

* chore(tauri.js) update changelog with window.tauri mapper (gist)

* chore(tauri.js) run rollup with silent flag

* chore(tauri): Resolve clippy warnings (#745)

* chore(readme) update documentation link

* fix(tauri.js) event payload type on TS API (#746)

* chore(bundler) improve "running script" log (#747)

* chore(changes) add bundler log improvement change file

* Fix/includedir (#751)

* fix(tauri) assets embedding regression

* fix(tauri) fix & optimize embedded assets

* fix: update docs with PAT (#743)

* feat: remove master branch, switch to git merge --ff-only (#744)

* feat: remove master branch, switch to git merge --ff-only

* rename pr-to-latest.yml

* feat(workflow) improve clippy check, add fmt and audit checks (#754)

* fix(tauri.js) transpile TS API and fix cjs/esm export (#752)

* Apply Version Updates From Current Changes (#748)

Co-authored-by: lucasfernog <lucas@tauri.studio>

* feat(tauri.js) validate tauri.conf.json schema on runtime (#756)

* chore: Fix typo on minuscule (#765)

Although this could be debated, "minuscule" seems to be the official spelling.

Source: https://www.merriam-webster.com/dictionary/miniscule

* fix: tauri past changelog had incorrect versions (#767)

It appears that the crossover with tauri.js also led to skipping 0.6.1 tauri crate publish.

* fix(tauri-bundler) appimage script (#766)

* Apply Version Updates From Current Changes (#758)

Co-authored-by: lucasfernog <lucas@tauri.studio>

* fix(bundler) dmg `unbounded variable` issue (#770)

* Apply Version Updates From Current Changes (#772)

Co-authored-by: lucasfernog <lucas@tauri.studio>

Co-authored-by: Jacob Bolda <me@jacobbolda.com>
Co-authored-by: Rajiv Shah <rajivshah1@icloud.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Francois Best <francois@francoisbest.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants