fix: use button property for data-tauri-drag-region mouse button detection, closes #7694#7746
Merged
Merged
Conversation
amrbashir
approved these changes
Sep 4, 2023
Member
amrbashir
left a comment
There was a problem hiding this comment.
I wouldn't consider this a breaking change but just to make sure, I will cc @lucasfernog
lucasfernog
approved these changes
Sep 7, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Does this PR introduce a breaking change?
Checklist
fix: remove a typo, closes #___, #___)Other information
#7694
Updated the
data-tauri-drag-regionattribute to use thebuttonproperty instead of thebuttonsproperty to check if the left mouse button was pressed.This change is intended to fix an issue that if the "Tap to Click" option is enabled on the macOS,
event.buttonswill return0and1randomly when tapping the element.Behavior changed
Before this patch, the
dragevent will be triggered only when the left mouse button is pressed. In this patch, if multiple mouse buttons are clicked along with the left mouse button simultaneously, it would see as the left mouse button clicked and trigger thedragevent.