Skip to content

feat: move window plugin back to core#8007

Merged
lucasfernog merged 10 commits intodevfrom
feat/window-plugin
Oct 17, 2023
Merged

feat: move window plugin back to core#8007
lucasfernog merged 10 commits intodevfrom
feat/window-plugin

Conversation

@amrbashir
Copy link
Member

@amrbashir amrbashir commented Oct 11, 2023 •
edited
Loading

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Docs
  • New Binding issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes, and the changes were approved in issue #___
  • No

Checklist

  • When resolving issues, they are referenced in the PR's title (e.g fix: remove a typo, closes #___, #___)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.
  • I have added a convincing reason for adding this feature, if necessary

Other information

@amrbashir amrbashir requested a review from a team as a code owner October 11, 2023 19:30
@amrbashir amrbashir marked this pull request as draft October 11, 2023 19:43
@amrbashir amrbashir marked this pull request as ready for review October 11, 2023 20:10
@amrbashir
Copy link
Member Author

amrbashir commented Oct 11, 2023

I will move the app plugin in another PR

amrbashir
amrbashir commented Oct 12, 2023
View reviewed changes
@lucasfernog lucasfernog merged commit c9a9246 into dev Oct 17, 2023
@lucasfernog lucasfernog deleted the feat/window-plugin branch October 17, 2023 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lucasfernog lucasfernog lucasfernog approved these changes

Assignees

No one assigned

Labels

None yet

Projects

Roadmap
Status: 🔎 In audit

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@amrbashir @lucasfernog