Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(bundler/nsis): only kill processes of current user #8390

Merged
merged 2 commits into from
Dec 13, 2023
Merged

fix(bundler/nsis): only kill processes of current user #8390

merged 2 commits into from
Dec 13, 2023

Conversation

amr-crabnebula
Copy link
Contributor

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Docs
  • New Binding issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes, and the changes were approved in issue #___
  • No

Checklist

  • When resolving issues, they are referenced in the PR's title (e.g fix: remove a typo, closes #___, #___)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.
  • I have added a convincing reason for adding this feature, if necessary

Other information

@amr-crabnebula @FabianLars-crabnebula
fix(bundler/nsis): only kill processes of current user
2114ab5 
Co-authored-by: FabianLars-crabnebula <fabianlars@crabnebula.dev>
@amr-crabnebula amr-crabnebula requested a review from a team as a code owner December 13, 2023 16:46
@amrbashir amrbashir merged commit 5ff9d45 into tauri-apps:1.x Dec 13, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amrbashir amrbashir amrbashir approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@amr-crabnebula @amrbashir