Skip to content

fix(core/updater): check if installer args are not empty before passing -ArgumentList closes #8296#8404

Merged
amrbashir merged 1 commit into1.xfrom
fix/updater/nsis-basicui
Dec 19, 2023
Merged

fix(core/updater): check if installer args are not empty before passing -ArgumentList closes #8296#8404
amrbashir merged 1 commit into1.xfrom
fix/updater/nsis-basicui

Conversation

@amrbashir
Copy link
Member

@amrbashir amrbashir commented Dec 14, 2023

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Docs
  • New Binding issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes, and the changes were approved in issue #___
  • No

Checklist

  • When resolving issues, they are referenced in the PR's title (e.g fix: remove a typo, closes #___, #___)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.
  • I have added a convincing reason for adding this feature, if necessary

Other information

@amrbashir amrbashir requested a review from a team as a code owner December 14, 2023 18:10
@amrbashir amrbashir merged commit 645e1dc into 1.x Dec 19, 2023
@amrbashir amrbashir deleted the fix/updater/nsis-basicui branch December 19, 2023 23:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants