Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tauri) notification body optional, requestPermission() regression, closes #793 #844

Merged
merged 2 commits into from
Jul 16, 2020

Conversation

lucasfernog
Copy link
Member

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • New Binding Issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes. Issue #___
  • No

The PR fulfills these requirements:

  • It's submitted to the dev branch and not the latest branch
  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix: #xxx[,#xxx], where "xxx" is the issue number)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:

@lucasfernog lucasfernog requested a review from a team as a code owner July 16, 2020 21:37
@lucasfernog lucasfernog requested review from a team July 16, 2020 21:37
@lucasfernog lucasfernog changed the title fix(tauri) notification body optional, requestPermission() regressioncloses #793 fix(tauri) notification body optional, requestPermission() regression, closes #793 Jul 16, 2020
@lucasfernog lucasfernog merged commit dac1db3 into dev Jul 16, 2020
@lucasfernog lucasfernog deleted the fix/notification-without-body branch July 18, 2020 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant