Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: implement covector publish #845

Merged
merged 11 commits into from
Jul 19, 2020
Merged

Conversation

jbolda
Copy link
Member

@jbolda jbolda commented Jul 17, 2020

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • New Binding Issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes. Issue #___
  • No

The PR fulfills these requirements:

  • It's submitted to the dev branch and not the latest branch
  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix: #xxx[,#xxx], where "xxx" is the issue number)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:
This implements publishing through covector and removes the bulk of the Github Actions handling publishing. With this, we can also remove the latest branch.

@jbolda
Copy link
Member Author

jbolda commented Jul 17, 2020

Adding a package.json at the root partly for devDeps and partly for better support of update bots such as renovate: renovatebot/renovate#4724

@jbolda
Copy link
Member Author

jbolda commented Jul 18, 2020

Outputs from actions can only be strings, hence that jq jazz. I think if we can move the tangle release to a package or a cli command, we may be able to remove all of that. (I think it may also end up running the second job on every merge, but not a great way to avoid it other than shifting tangle I believe.) @rajivshah3 do you have any thoughts on that?

@rajivshah3
Copy link
Member

Hmm, yeah the jq stuff isn't ideal. @obany do you think we can make a standalone NPM package for the Tangle Release and then just have the GH action be a wrapper around that?

@jbolda jbolda marked this pull request as ready for review July 19, 2020 14:17
@jbolda jbolda requested a review from a team as a code owner July 19, 2020 14:17
@jbolda jbolda requested a review from a team July 19, 2020 14:17
@jbolda jbolda merged commit 2d72132 into dev Jul 19, 2020
@jbolda jbolda deleted the chore/implement-covector-publish branch July 19, 2020 20:33
@obany
Copy link

obany commented Jul 20, 2020

Hmm, yeah the jq stuff isn't ideal. @obany do you think we can make a standalone NPM package for the Tangle Release and then just have the GH action be a wrapper around that?

@rajivshah3 So a lib that can be referenced by the current GH Action and with a CLI as well ?

@jbolda
Copy link
Member Author

jbolda commented Jul 20, 2020

@obany yea, something like that. That is how covector is setup. Mostly because it is rather complicated/fragile to get these actions setup and it helps being able to run something locally. Also the only way to "dynamically loop" through something is to spin up multiple machines which only increases the complexity (and run time).

@obany
Copy link

obany commented Jul 22, 2020

Just released v0.7.0 of the action (which actually behaves the same as the old one from a GHA perspective)

But the core is completely rewritten in TypeScript and refactored so that it can also be executed as a CLI from it's npm package.

https://www.npmjs.com/package/@iota/gh-tangle-release (CLI instructions at bottom of README)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants