Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(tauri-build): add config-json feature flag #8732

Merged
merged 6 commits into from
Feb 2, 2024

Conversation

amrbashir
Copy link
Member

This allows disabling rebuilding when tauri.conf.json when using another config format

see #8721

This allows disabling rebuilding when `tauri.conf.json` when using another config format

see #8721
@amrbashir amrbashir requested a review from a team as a code owner February 2, 2024 02:44
core/tauri/src/lib.rs Outdated Show resolved Hide resolved
lucasfernog
lucasfernog previously approved these changes Feb 2, 2024
Copy link
Member

@lucasfernog lucasfernog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was not working without 96dea02, always remember to check your changes with the API example

@lucasfernog lucasfernog merged commit e8d3793 into dev Feb 2, 2024
26 checks passed
@lucasfernog lucasfernog deleted the feat/tauri-build/config-json branch February 2, 2024 17:12
@amrbashir
Copy link
Member Author

amrbashir commented Feb 2, 2024

I always test with a fresh example from CTA or helloworld example, for some reason I hate working on the api example 😅 and try to avoid it, but looks like I didn't test this well

@FabianLars
Copy link
Member

same, i also avoid the api example and go for CTA and my 3+ year old tauri app 😂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants