refactor(core): allow referencing capabilities on the Tauri config file#8797
Merged
Conversation
Member
Author
|
Maybe we should default to include all capabilities if the config array is empty? I know @FabianLars would like that so we won't deal with another "hidden" breaking change. |
Member
|
Yup, probably. But it's still beta so if it's objectively better than just break it 🤷 (i also don't really get the issue itself tbh so idk) |
Member
Author
|
I like how the latest change is a balance between DX and configurability. |
amrbashir
requested changes
Feb 7, 2024
amrbashir
approved these changes
Feb 16, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current capability file design automatically adds all files in the capabilities folder to the application. While this is convenient for the developer, it restricts dynamic use cases (for instance plugins that are only enabled on debug or with an associated Cargo feature). After talking with @tweidinger we agreed we should add a reference on tauri.conf.json where the dev must specify which capabilities to include.
This PR adds a capabilities array inside app > security > capabilities where you can reference capabilities by identifier or inline capability objects (though this one isn't ideal since it lacks JSON schema support).
I'll open an issue later today detailing the dynamic capability implementation we can support.