fix: target specific window for window events

[vonPB]

When using the onCloseRequested JS Api, the event was triggered even when closing other windows, not just the one of interest.

I believe it would be more logical for this event to be dispatched exclusively for the current window's close requests.

Before:

before.mp4

After:

after.mp4

[amrbashir]

Nice catch, I believe all window events should use emit_filter and target, EventTarget::Any, EventTarget::Window and EventTarget::WebviewWindow

[vonPB]

Nice catch, I believe all window events should use emit_filter and target, EventTarget::Any, EventTarget::Window and EventTarget::WebviewWindow

Thanks for the feedback @amrbashir, I've changed the emit_to to emit_filter.
However, I'm curious about your suggestions to use EventTarget::Any as well. Wouldn't Any already target the others inherently? This would also continue to send the close requested event to all windows...

Or did you just mean to say that all events should use emit_filter?

[amrbashir]

You're right, no need to target EventTarget::Any, I suggested that so the event would still trigger listeners from app.listen_any but it will be emitted to it anyway. For this PR, EventTarget::Window and EventTarget::WebviewWindow should be enough.

[vonPB]

Ah, gotcha. So even if there is no matchingWindow or WebviewWindow the event should still be emitted internally for listen_any to catch, right? 257e95b

[amrbashir]

Thank you