feat(bundler): hide output from shell scripts unless --verbose is passed (fixes #888) #893
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nklayman
changed the title
lucasfernog
reviewed
Jul 26, 2020
| @@ -74,7 +74,7 @@ pub fn bundle_project(settings: &Settings) -> crate::Result<Vec<PathBuf>> { | |||
|
|
|||
| // create the shell script file in the target/ folder. | |||
| let sh_file = output_path.join("build_appimage.sh"); | |||
| common::print_bundling(format!("{:?}", &appimage_path).as_str())?; | |||
There was a problem hiding this comment.
why did you change this from the full path to the filename? Every other place is still the full path.
There was a problem hiding this comment.
The .deb bundle log shows just the file name. The full path is displayed after anyways.
lucasfernog
approved these changes
Jul 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (check at least one)
Does this PR introduce a breaking change? (check one)
The PR fulfills these requirements:
fix: #xxx[,#xxx], where "xxx" is the issue number)If adding a new feature, the PR's description includes:
Other information:
As per #888, I think the platform build scripts' output is way too verbose. This PR will hide all the output from those scripts so that they match the behavior of pure rust bundlers.
To Do:
stderralways shows some info text for some reason, even on success)Rather than fix stderr, I just added a notice about
--verboseif the script fails (dmg/appimage only)