refactor(core): allow configuring both local and remote URLs on capability#8950
Merged
lucasfernog merged 1 commit intodevfrom Feb 22, 2024
Merged
refactor(core): allow configuring both local and remote URLs on capability#8950lucasfernog merged 1 commit intodevfrom
lucasfernog merged 1 commit intodevfrom
Conversation
amrbashir
approved these changes
Feb 22, 2024
Member
|
Could we maybe change it to {
"context": ["local", { "remote": ["https://url.com"] }]
}Seems like it would allow for future additions if needed |
Member
Author
|
that was my first idea, but that also allows to weird configurations like |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current capability format allows you to configure either a capability that applies to local URLs or to a list of remote URLs. This forces users to have to define two identical capability files if they choose to enable a set of permissions both locally and to remote URLs.
This PR changes the model from
context: local | { remote: { urls: string[] } }toremote: { urls: string[] }, local: bool