Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(core): multiwebview mode fixes for auto resize, reparent and add_child #8999

Merged
merged 9 commits into from
Feb 27, 2024
Merged

fix(core): multiwebview mode fixes for auto resize, reparent and add_child #8999

merged 9 commits into from
Feb 27, 2024

Conversation

lucasfernog
Copy link
Member

This PR includes fixes for the multiwebview mode.

  • Webview::reparent not updating the webview parent window reference
  • Window::add_child deadlock
  • autoresize

@lucasfernog lucasfernog requested a review from a team as a code owner February 27, 2024 14:47
@amrbashir amrbashir mentioned this pull request Feb 27, 2024
Closed
@lucasfernog lucasfernog merged commit 222a96b into dev Feb 27, 2024
20 checks passed
@lucasfernog lucasfernog deleted the refactor/multiwebview branch February 27, 2024 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amrbashir amrbashir amrbashir approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@lucasfernog @amrbashir