Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor!(core): remove Icon enum and add Image type #9011

Merged
merged 17 commits into from
Feb 29, 2024
Merged

Conversation

amrbashir
Copy link
Member

@amrbashir amrbashir commented Feb 28, 2024

No description provided.

@amrbashir amrbashir requested a review from a team as a code owner February 28, 2024 01:07
@amrbashir
Copy link
Member Author

I will add the equivalent JS types later on another PR

.changes/runtime-icon-lifetime.md Outdated Show resolved Hide resolved
.changes/ico-featrue-flags.md Outdated Show resolved Hide resolved
core/tauri/src/image.rs Outdated Show resolved Hide resolved
#[cfg(desktop)]
#[derive(serde::Deserialize)]
#[serde(untagged)]
pub enum JsIcon<'a> {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why isn't this called JsImage?

Copy link
Member Author

@amrbashir amrbashir Feb 28, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have no idea tbh 😅, I will open another PR for JS implementation and will refactor it later.

@lucasfernog lucasfernog merged commit d1e77ac into dev Feb 29, 2024
25 checks passed
@lucasfernog lucasfernog deleted the feat/image-type branch February 29, 2024 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants