-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor!(core): remove Icon
enum and add Image
type
#9011
Conversation
I will add the equivalent JS types later on another PR |
#[cfg(desktop)] | ||
#[derive(serde::Deserialize)] | ||
#[serde(untagged)] | ||
pub enum JsIcon<'a> { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why isn't this called JsImage?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have no idea tbh 😅, I will open another PR for JS implementation and will refactor it later.
No description provided.