Skip to content

fix(cli): Truncate BuildTask.kt before writing#9015

Merged
lucasfernog merged 3 commits intotauri-apps:devfrom
i-c-b:fix-init-android-studio-buildtask
Feb 28, 2024
Merged

fix(cli): Truncate BuildTask.kt before writing#9015
lucasfernog merged 3 commits intotauri-apps:devfrom
i-c-b:fix-init-android-studio-buildtask

Conversation

@i-c-b
Copy link
Contributor

@i-c-b i-c-b commented Feb 28, 2024

No description provided.

@i-c-b i-c-b requested a review from a team as a code owner February 28, 2024 04:04
@i-c-b
Copy link
Contributor Author

i-c-b commented Feb 28, 2024

I also noticed the same code for tauri ios init and tauri plugin init --android / tauri plugin android init but neither seems to have BuildTask.kt in their template files. Should I remove their checks for the file?

@amrbashir
Copy link
Member

amrbashir commented Feb 28, 2024

I think Lucas fixed the android part in #9009 , feel free to just truncate on other platforms.

@lucasfernog
Copy link
Member

lucasfernog commented Feb 28, 2024 •
edited
Loading

can't we always truncate?
EDIT: ahh we didn't want to mess with existing files.. let's go with this then

@lucasfernog lucasfernog merged commit b658ded into tauri-apps:dev Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lucasfernog lucasfernog lucasfernog approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@i-c-b @amrbashir @lucasfernog