Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cli): migrate to stable features of log crate #9119

Merged
merged 2 commits into from
Mar 7, 2024
Merged

Conversation

amrbashir
Copy link
Member

@amrbashir amrbashir commented Mar 7, 2024

ref: #9026

@amrbashir amrbashir requested a review from a team as a code owner March 7, 2024 16:05
@lucasfernog lucasfernog merged commit 97a0514 into 1.x Mar 7, 2024
21 checks passed
@lucasfernog lucasfernog deleted the fix/log-unstable branch March 7, 2024 16:39
@kiprasmel
Copy link

@amrbashir when using ./.scripts/setup.sh, i am getting an error exactly about this:

error[E0599]: no method named `to_str` found for struct `log::kv::Value` in the current scope
   --> src/lib.rs:132:29
    |
132 |         let action = action.to_str().unwrap();
    |                             ^^^^^^ help: there is a method with a similar name: `to_cow_str`

For more information about this error, try `rustc --explain E0599`.
error: could not compile `tauri-cli` (lib) due to 1 previous error
warning: build failed, waiting for other jobs to finish...
error: failed to compile `tauri-cli v1.5.10 (/Users/kipras/forkprojects/tauri/tooling/cli)`, intermediate artifacts can be found at `/Users/kipras/forkprojects/tauri/tooling/cli/target`.
To reuse those artifacts with a future compilation, set the environment variable `CARGO_TARGET_DIR` to that path.
Tauri Rust CLI installed. Run it with '$ cargo tauri [COMMAND]'.
Do you want to install the Node.js CLI?
1) Yes
2) No

what am i doing wrong?

env:

$ cargo --version  
cargo 1.76.0 (c84b36747 2024-01-18)

$ rustc --version
rustc 1.76.0 (07dca489a 2024-02-04)

$ yarn --version                        
1.22.21

@amrbashir
Copy link
Member Author

sounds like you didn't pull the latest commits of whatever branch you're using

@kiprasmel
Copy link

yeah i'm using 1.x, looks like you're right. thanks

amrbashir added a commit that referenced this pull request Apr 18, 2024
* chore: port PR template from `dev` branch (#9004)

* fix(runtime-wry): avoid panic during clipboard initialization on wayland (#9003)

closes #8964

* ci: downgrade thread_local to 1.1.7 in msrv list (#9012)

* Apply Version Updates From Current Changes (v1) (#9013)

Co-authored-by: lucasfernog <lucasfernog@users.noreply.github.com>

* fix(bundler): escape potentially problematic strings in an XML (#9040)

* fix(bundler): escape potentially problematic strings in an XML (#9030)

- replace characters invalid in XML with their escaped form to properly bundle resources with such characters in their pathnames.

* change file

* fix(cli): use `matched_path_or_any_parents` when checking if a file is ignored (#8903)

* fix: taurignore ignoreing folders not working for watch

* docs: add to changes

* fix: panic: path is expected to be under the root

* Update taurignore-ignoring-folders-not-working-for-watch.md

* Update taurignore-ignoring-folders-not-working-for-watch.md

* fix(cli): migrate to stable features of `log` crate (#9119)

* fix(cli): migrate to stable features of `log` crate

* to_cow_str

* Apply Version Updates From Current Changes (v1) (#9074)

Co-authored-by: lucasfernog <lucasfernog@users.noreply.github.com>

* fix(core/path): remove suffix in basename only once (#9166)

* fix(core/path): remove suffix in basename only once

ref: #9064

* Update tooling/api/src/path.ts

---------

Co-authored-by: Lucas Fernandes Nogueira <lucas@tauri.app>

* fix(cli): Clone Options struct after mutating it. (#9188)

* fix(bundler): Fix nsis resource paths on non-windows build systems. (#9281)

* fix(bundler): Fix nsis resource paths on non-windows build systems.

* remove leftover from alternative

* fix(bundler/nsis): Don't use /R flag on installation dir (#9282)

* fix(cli): upgrade heck to better support Chinese/Japanese prodcut name on Linux (#9298)

* chore: fix clippy false positive (#9329)

* fix(cli/info): fix crash when checking node version (#9411)

closes #9396

---------

Co-authored-by: Amr Bashir <amr.bashir2015@gmail.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: lucasfernog <lucasfernog@users.noreply.github.com>
Co-authored-by: bifs <127015052+bifs@users.noreply.github.com>
Co-authored-by: anatawa12 <anatawa12@icloud.com>
Co-authored-by: Lucas Fernandes Nogueira <lucas@tauri.app>
Co-authored-by: Jet Li <jing.i.qin@icloud.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants