Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(image): expose constructor, unify size getters #9179

Merged
merged 4 commits into from
Mar 14, 2024

Conversation

lucasfernog
Copy link
Member

  • Expose Image JS constructor for internal use (when a plugin returns a resource id for instance)
  • Added Image::size() instead of Image::width() and Image::height() (1 IPC call instead of 2 - usually you want both width and height)

@lucasfernog lucasfernog requested a review from a team as a code owner March 13, 2024 15:23
Co-authored-by: Amr Bashir <amr.bashir2015@gmail.com>
@lucasfernog lucasfernog merged commit ea0242d into dev Mar 14, 2024
25 checks passed
@lucasfernog lucasfernog deleted the refactor/image-constructor-and-size branch March 14, 2024 01:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants