feat(bundler): add post/pre install/remove scripts for linux deb and rpm packages

[vlabo]

New configuration options:

"bundle": {
    "linux": {
      "deb": {
        "scripts": {
          "preInstall": "./preinst_script.sh",
          "postInstall": "./postinst_script.sh",
          "preRemove": "./prerm_script.sh",
          "postRemove": "./postrm_script.sh"
        }
      },
      "rpm": {
        "scripts": {
          "preInstall": "./preinst_script.sh",
          "postInstall": "./postinst_script.sh",
          "preRemove": "./prerm_script.sh",
          "postRemove": "./postrm_script.sh"
        }
      }
    }
  }

I fallowed the official implementation for debian packages:
https://www.debian.org/doc/debian-policy/ch-maintainerscripts.html

For rpm package I used the already available functions from the rpm crate:
https://docs.rs/rpm/0.14.0/rpm/struct.PackageBuilder.html#method.pre_install_script
https://docs.rs/rpm/0.14.0/rpm/struct.PackageBuilder.html#method.post_install_script
https://docs.rs/rpm/0.14.0/rpm/struct.PackageBuilder.html#method.pre_uninstall_script
https://docs.rs/rpm/0.14.0/rpm/struct.PackageBuilder.html#method.post_uninstall_script

closes #9192
closes #8993

[naman-crabnebula]

Hi there!

I ( not sure of others ) would prefer having the script options under the DebianSettings and RpmSettings itself, and should not create a separate DebScripts or Rpmscripts struct for that.

[FabianLars]

So you mean like this?

{
  "deb":
    "pre_install": "",
    "post_install": "",
    ...
}

I could see that working too but i'd also like to hear the others' opionions. That said, if we do keep a struct (which imo is fine too) then i think we should have one generic struct and reuse it in both deb and rpm.

[vlabo]

Im fine with both solutions. With or without struct.
But I think it will be good to keep them separate. A generic struct will work for this settings but they are still separate formats.

In rpm there is a lot more settings related to the scripts compared to deb packages.
For reference: https://docs.fedoraproject.org/en-US/packaging-guidelines/Scriptlets/#ordering

[FabianLars]

Right, i meant to re-use the same struct declaration but keep the respective deb/rpm configs, similar to HookCommand for beforeXCommand

[vlabo]

I removed the script structs now the config looks like this:

"bundle": {
      "linux": {
          "deb": {
              "preInstallScript": "./preinst_script.sh",
              "postInstallScript": "./postinst_script.sh",
              "preRemoveScript": "./prerm_script.sh",
              "postRemoveScript": "./postrm_script.sh"
          },
          "rpm": {
              "preInstallScript": "./preinst_script.sh",
              "postInstallScript": "./postinst_script.sh",
              "preRemoveScript": "./prerm_script.sh",
              "postRemoveScript": "./postrm_script.sh"
          }
     }
}

It seem like the cleaner solution to me. But the maintainers opinions is more important.
Please let me know if you want me to change anything before this can be merged.