feat(cli): add macos hardened runtime signing config option#9318
Merged
FabianLars merged 8 commits intotauri-apps:devfrom Jun 5, 2024
Merged
Conversation
Contributor
Author
|
Just a gentle reminder: I'm currently unable to test my app build locally due to the damaged |
FabianLars
requested changes
Jun 5, 2024
Member
FabianLars
left a comment
There was a problem hiding this comment.
Thanks, just some smaller things and then it's good to go :)
Contributor
Author
|
Thanks for the review : - ) |
FabianLars
approved these changes
Jun 5, 2024
pewsheen
pushed a commit
to pewsheen/tauri
that referenced
this pull request
Jun 13, 2024
…ps#9318) * feat(cli): add macos signing config option * rename option to hardened_runtime * chore(cli): use default true in hardened runtime config --------- Co-authored-by: Lucas Nogueira <lucas@tauri.app>
FabianLars
added a commit
that referenced
this pull request
Jul 4, 2024
* feat(cli): add macos signing config option * rename option to hardened_runtime * chore(cli): use default true in hardened runtime config --------- Co-authored-by: Lucas Nogueira <lucas@tauri.app>
amrbashir
pushed a commit
that referenced
this pull request
Jul 8, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In
macOS, when buildingdmgwithad-hocsignature, and the app depends on Frameworks (dynamic shared libraries,dylibfiles), they won't load and the app will crash with error message box.I found that if we disable signing flag in
macOSbundler passed fromtauri-cli, it won't crash.the flag which passed is
--option runtimein tooling/bundler/src/bundle/macos/sign.rs#L210crash log
man codesign
This PR introduce a way to control the flag through
tauri.conf.json:I believe that macOS bundling process needs to be much more flexible.
Currently I have no other option to control the final signing of the app, and tauri enforce this
runtimeflag, as a result the final binary can't run and I can't publish it for macOS (arm).meanwhile for testing the app, it's possible to resign it: