-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(windows): nsis failed to resolve resources with $
in their name, closes #9657
#9659
fix(windows): nsis failed to resolve resources with $
in their name, closes #9657
#9659
Conversation
Thanks for your contributions. I did a bit of experiments and seems like only the input to |
@amrbashir |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, just a couple of more to go
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you
$
in their name. closes #9657$
in their name, closes #9657
Registering a global escape function that replaces
$
with$$
in Handlebars causes the build step to fail when resources contain$
in their names, because NSIS commands likeFile /a
cannot resolve the escaped paths. #9657I've added a helper that unescapes
$$
back to$
and modified the corresponding resource expression ininstaller.nsi
to use this helper.If there are better solutions, I'd be happy to implement them.