-
-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[v2] nsis: add files #9661
[v2] nsis: add files #9661
Conversation
The |
That's good to know. However Right now I am using Even if |
You can have OS specific configs (that overwrite the main config) -> https://tauri.app/v1/api/config#platform-specific-configuration
I did not disagree with the "Further thoughs" section of your PR description, i just think it's off-topic with this PR and should have its own issue/PR :) |
Thanks again. The merged config could work in my case, at least I wouldn't have to copy files manually. Since it's not documented how to write the resources map, could you please maybe shed some light on how does one specify the glob pattern in map, i.e should it be this: "resources": {
"tray-icons/": "tray-icons/*.png",
} or that? "resources": {
"tray-icons/*.png": "tray-icons/*.png",
} I'll make sure to create another issue in regards of nsis installer hooks. Update: it seems that resource map works different from Maybe that's because when building a universal mac binary, my workspace binaries aren't compiled into If I got it right, the syntax is inverted here, i.e key is path to file, value is where to put it in installer. Keys and values are flipped in that sense in "resources": {
"../../target/release/my-other-bin.exe": "my-other-bin.exe"
} I'll create an issue for that too 😓 |
I see no reason to include this option, as your use-case is already covered by |
This PR adds support for
files
for NSIS installer, similar setting can be found undermacOS
configuration. The rationale for adding this is the following:files
section makes it possible to bundle external binaries and their resources under individual folders. External binaries setting does not provide such flexibility.Further thoughts
Making custom
installer.nsi
is difficult. It would be better to provide a way to have a pre and post install hooks. Maybe we could include custom.nsh
files that would augment the behavior oftemplates/installer.nsi
.This is still work in progress and I am not able to test it. Somehow I keep stumbling upon the following error which is a dead end given that it does mention the source of this error:
Closes #9652