fix(core/shell): speedup Command.execute & fix extra new lines
#9706
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The speed gains comes from running the Command in Rust fully and returning the result in one go instead of using events. The extra new lines was a regression from #6519 ref: #7684 (comment)
lucasfernog
reviewed
May 9, 2024
core/tauri/src/endpoints/shell.rs
Outdated
| ) -> super::Result<ChildProcessReturn> { | ||
| let mut command = prepare_cmd(&context, &program, args, &options)?; | ||
|
|
||
| #[cfg(any(shell_execute, shell_sidecar))] |
There was a problem hiding this comment.
why isn't this cfg on the function itself?
There was a problem hiding this comment.
wait actually the cfg is not needed at all
lucasfernog
approved these changes
May 9, 2024
amrbashir
added a commit
that referenced
this pull request
May 15, 2024
amrbashir
added a commit
that referenced
this pull request
May 15, 2024
* fix(core/shell): speedup `Command.execute` & fix extra new lines The speed gains comes from running the Command in Rust fully and returning the result in one go instead of using events. The extra new lines was a regression from #6519 ref: #7684 (comment) * fix unix build * clippy * cleanup --------- Co-authored-by: Lucas Nogueira <lucas@tauri.app>
lucasfernog
added a commit
that referenced
this pull request
May 24, 2024
* fix(core/shell): speedup `Command.execute` & fix extra new lines (#9706) * fix(core/shell): speedup `Command.execute` & fix extra new lines The speed gains comes from running the Command in Rust fully and returning the result in one go instead of using events. The extra new lines was a regression from #6519 ref: #7684 (comment) * fix unix build * clippy * cleanup --------- Co-authored-by: Lucas Nogueira <lucas@tauri.app> * lock file * minor --------- Co-authored-by: Lucas Nogueira <lucas@tauri.app> Co-authored-by: Lucas Nogueira <lucas@tauri.studio>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The speed gains comes from running the Command in Rust fully and returning the result in one go instead of using events.
The extra new lines was a regression from #6519
ref: #7684 (comment)