Skip to content

fix(android): allow and escape Kotlin keywords as package identifier, closes #9743#9799

Merged
lucasfernog merged 8 commits into
tauri-apps:devfrom
pewsheen:fix/escape-kotlin-keyword
May 28, 2024
Merged

fix(android): allow and escape Kotlin keywords as package identifier, closes #9743#9799
lucasfernog merged 8 commits into
tauri-apps:devfrom
pewsheen:fix/escape-kotlin-keyword

Conversation

@pewsheen

@pewsheen pewsheen commented May 16, 2024

Copy link
Copy Markdown
Contributor

Issue: #9743
Depends: tauri-apps/cargo-mobile2#328

How to test

  • Create a project named with Kotlin keyword, such as when or object
  • Modify identifier in tauri.config.json -> aa.fun.tauri.dev
  • Call cargo tauri android init - Should be able to init, and the package name in src-tauri/gen/android/app/src/main/java/aa/fun/tauri/when/MainActivity.kt should be "aa.`fun`.tauri.`when`"
  • Able to run cargo tauri android dev

TODO

@pewsheen pewsheen marked this pull request as ready for review May 28, 2024 03:48
@pewsheen pewsheen requested a review from a team as a code owner May 28, 2024 03:48
@lucasfernog lucasfernog merged commit 71a5e2b into tauri-apps:dev May 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants