Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(plugin): add option to use a Xcode project for iOS #9843

Merged
merged 9 commits into from
May 24, 2024

Conversation

lucasfernog
Copy link
Member

Currently plugin authors are forced to use SwiftPM for their iOS library. This PR adds support to a plain Xcode project (also using Swift under the hood) that is compiled using xcodebuild. This solves some SwiftPM limitations e.g. not being able to use dependencies that relies on XCFrameworks and other quirks such as firebase, GoogleSignIn-iOS, etc.

@lucasfernog lucasfernog requested a review from a team as a code owner May 21, 2024 14:02
amrbashir
amrbashir previously approved these changes May 21, 2024
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to template xcuserdata?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure @pewsheen I only generated a new Xcode Swift static library project and moved here :D

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this can probably be removed - let me double check

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

deleted, nice catch!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's safe to remove the xcuserdata folder. It'll regenerate a new one next time we build or open it with Xcode. Another reason is it's based on the user name on Mac I guess, so it might recreate it anyway.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i did delete it but i just forgot to actually comment on this review

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems forgot to delete this one 👀

tooling/cli/templates/plugin/ios-xcode/tauri-plugin-{{ plugin_name }}.xcodeproj/project.xcworkspace/xcuserdata/lucas.xcuserdatad/UserInterfaceState.xcuserstate

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ooh nice catch, fixed @pewsheen

@pewsheen
Copy link
Contributor

Everything looks good!

I don't have the write access to approve the review, maybe @amrbashir can help approve it again 😅

@lucasfernog lucasfernog merged commit 8a1ae2d into dev May 24, 2024
26 checks passed
@lucasfernog lucasfernog deleted the fix/swift-build branch May 24, 2024 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants