Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor!: use tauri.conf.json > identifier as package name and bundle id, close #9851 #9858

Merged
merged 14 commits into from
May 24, 2024
Merged

refactor!: use tauri.conf.json > identifier as package name and bundle id, close #9851 #9858

merged 14 commits into from
May 24, 2024

Conversation

pewsheen
Copy link
Contributor

@pewsheen pewsheen commented May 23, 2024 •
edited
Loading

Close: #9851

Use tauri.config.json > identifier as the package name (Android) and bundle ID (iOS)

TODO:

  • Android
  • iOS
  • update cargo-mobile2 version

Depends: tauri-apps/cargo-mobile2#330

@pewsheen pewsheen changed the title fix: use tauri.config.json > identifier as package name and bundle id, close #9851 refactor: use tauri.config.json > identifier as package name and bundle id, close #9851 May 23, 2024
@pewsheen pewsheen changed the title refactor: use tauri.config.json > identifier as package name and bundle id, close #9851 refactor!: use tauri.config.json > identifier as package name and bundle id, close #9851 May 23, 2024
@pewsheen pewsheen changed the title refactor!: use tauri.config.json > identifier as package name and bundle id, close #9851 refactor!: use tauri.conf.json > identifier as package name and bundle id, close #9851 May 24, 2024
lucasfernog
lucasfernog reviewed May 24, 2024
View reviewed changes
Copy link
Member

@lucasfernog lucasfernog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nitpick

.changes/mobile-use-identifier-as-id.md Show resolved Hide resolved
core/tauri-build/src/lib.rs Outdated Show resolved Hide resolved
@lucasfernog lucasfernog marked this pull request as ready for review May 24, 2024 12:01
@lucasfernog lucasfernog requested a review from a team as a code owner May 24, 2024 12:01
@lucasfernog lucasfernog merged commit 1df5cde into tauri-apps:dev May 24, 2024
27 of 28 checks passed
@pewsheen pewsheen deleted the fix/use-tauri-identifier branch May 24, 2024 14:53
@BSteffaniak BSteffaniak mentioned this pull request Jun 9, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucasfernog lucasfernog lucasfernog approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[bug] Tauri 2: iOS app's bundle identifier does not use tauri.conf.json
2 participants
@pewsheen @lucasfernog