Skip to content

refactor!: use tauri.conf.json > identifier as package name and bundle id, close #9851#9858

Merged
lucasfernog merged 14 commits into
tauri-apps:devfrom
pewsheen:fix/use-tauri-identifier
May 24, 2024
Merged

refactor!: use tauri.conf.json > identifier as package name and bundle id, close #9851#9858
lucasfernog merged 14 commits into
tauri-apps:devfrom
pewsheen:fix/use-tauri-identifier

Conversation

@pewsheen
Copy link
Copy Markdown
Contributor

@pewsheen pewsheen commented May 23, 2024

Close: #9851

Use tauri.config.json > identifier as the package name (Android) and bundle ID (iOS)

TODO:

  • Android
  • iOS
  • update cargo-mobile2 version

Depends: tauri-apps/cargo-mobile2#330

@pewsheen pewsheen changed the title fix: use tauri.config.json > identifier as package name and bundle id, close #9851 refactor: use tauri.config.json > identifier as package name and bundle id, close #9851 May 23, 2024
@pewsheen pewsheen changed the title refactor: use tauri.config.json > identifier as package name and bundle id, close #9851 refactor!: use tauri.config.json > identifier as package name and bundle id, close #9851 May 23, 2024
@pewsheen pewsheen changed the title refactor!: use tauri.config.json > identifier as package name and bundle id, close #9851 refactor!: use tauri.conf.json > identifier as package name and bundle id, close #9851 May 24, 2024
Copy link
Copy Markdown
Member

@lucasfernog lucasfernog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nitpick

Comment thread .changes/mobile-use-identifier-as-id.md
Comment thread core/tauri-build/src/lib.rs Outdated
@lucasfernog lucasfernog marked this pull request as ready for review May 24, 2024 12:01
@lucasfernog lucasfernog requested a review from a team as a code owner May 24, 2024 12:01
@lucasfernog lucasfernog merged commit 1df5cde into tauri-apps:dev May 24, 2024
@pewsheen pewsheen deleted the fix/use-tauri-identifier branch May 24, 2024 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[bug] Tauri 2: iOS app's bundle identifier does not use tauri.conf.json

2 participants