fix(core/wry): implement resizing natively on Windows

[amrbashir]

closes #7388
closes #9510
closes #9464
closes #9881

ref #9268
ref #9053
ref #8770
ref #8750
ref #4012

[FabianLars]

Sorry for the long delay on the review here...

The resizing itself works really well, good job!

You said you wanted to add support for the controls too, right? Asking because if users imitate native controls then the resize handles will conflict with it at the border a bit.
Even if not, imo it'd be a good tradeoff (especially if we add bordered mode too idk), just wanna be upfront about it.

[amrbashir]

You said you wanted to add support for the controls too, right? Asking because if users imitate native controls then the resize handles will conflict with it at the border a bit.
Even if not, imo it'd be a good tradeoff (especially if we add bordered mode too idk), just wanna be upfront about it.

That should be in another PR, and most likely resize handles will take priority over buttons

[FabianLars]

That should be in another PR

Of course

and most likely resize handles will take priority over buttons

Yeah, that's how this PR already behaves with html/js buttons which is why i'm asking, cause this is different to native/electron. But again, i'm fine with that, just wanted to talk about it once so we're all on the same page.

[amrbashir]

cause this is different to native/electron.

Sure native behaves differently but that's out of scope of this PR since we can't achieve similar things as native (not yet at least) but I am curious how electron behaves with WCO or custom HTML buttons.

[FabianLars]

in vscode for example (and other random electron apps I have installed) the buttons behave like native == only have a 1px resize handle (feels less than 1px tbh). Basically as if the buttons float above the resize handles.

[amrbashir]

Just tested electron and I don't see them doing anything special, the resize border size is consistent whether there is a button or not so it is safe to say they have the same behavior as us (maybe our resize border size is a little bit bigger?)

[FabianLars]

Maybe the apps i tested used WCO 🤷

maybe our resize border size is a little bit bigger?

Now that you mention it, yes that's also the case. (imo good because for me electron's handles are too small)

[amrbashir]

Can we merge this and get it in the hand of users to test so we can see if there is any bugs or if the border size needs a bit of tweaking?

[FabianLars]

fine with me