fix(nsis): run app as normal user #9944
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Don't want to solve merge conflicts, waiting for #9915 to get merged first |
amrbashir
requested changes
Jun 4, 2024
There was a problem hiding this comment.
I tried so hard to review this PR and even though you did a great job documenting each call, I still find it error prone and unmaintainable. However, I couldn't find an easier alternative.
I think the right thing to do this logic in Rust in nsis-tauri-utils as part of the nsis-process plugin.
Would you like to work on that @Legend-Master?
|
I could give it a try, didn't work on no std rust before, but guess it wouldn't be harder than nsis 😂 |
|
Don't worry I think the existing functions there can guide you but If you need help, just let me know |
amrbashir
requested changes
Jun 6, 2024
amrbashir
approved these changes
Jun 6, 2024
anatawa12
pushed a commit
to anatawa12/tauri
that referenced
this pull request
Jun 6, 2024
(cherry picked from commit 6f46953)
FabianLars
pushed a commit
that referenced
this pull request
Jun 6, 2024
pewsheen
pushed a commit
to pewsheen/tauri
that referenced
this pull request
Jun 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #9835
Reference: https://devblogs.microsoft.com/oldnewthing/20190425-00/?p=102443