-
-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: improve checking for Rez (fix #994) #995
Conversation
Check for Rez in Xcode.app and in command line tools, and error if neither is installed.
This reverts commit 54784a0. I'm not sure that this string substition will work how I want it to.
There's no pretty error message telling folks to install command line tools for xcode, however I'm pretty sure that the error stack will make it pretty obvious with a single google search what the problem is. There's about a million Medium articles explaining how to run |
Ok so CI failed, but I'm not sure it was related to my change. Relevant output: info sharp Downloading https://github.com/lovell/sharp-libvips/releases/download/v8.9.1/libvips-8.9.1-darwin-x64.tar.gz
ERR! sharp connect ETIMEDOUT 52.216.160.155:443
info sharp Attempting to build from source via node-gyp but this may fail due to the above error I think this is just a network timeout. I've seen some stuff about this being an issue, I wonder if triggering a re-run will fix it. |
Could you do something like |
Actually, you could add to the error message here:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks again for your help with this!
Check for Rez in Xcode.app and in command line tools, and error if neither is installed.
What kind of change does this PR introduce? (check at least one)
Fixes #994
Does this PR introduce a breaking change? (check one)
The PR fulfills these requirements:
fix: #xxx[,#xxx]
, where "xxx" is the issue number)If adding a new feature, the PR's description includes:
Other information:
I haven't tested this at all, this is just my naïve attempt to fix this behavior. Please let me know what I've done wrong and I'll correct it. ❤️