Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: improve checking for Rez (fix #994) #995

Merged
merged 7 commits into from
Aug 28, 2020
Merged

fix: improve checking for Rez (fix #994) #995

merged 7 commits into from
Aug 28, 2020

Conversation

caass
Copy link
Contributor

@caass caass commented Aug 27, 2020

Check for Rez in Xcode.app and in command line tools, and error if neither is installed.

What kind of change does this PR introduce? (check at least one)
Fixes #994

  • Bugfix
  • Feature
  • New Binding Issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes. Issue #___
  • No

The PR fulfills these requirements:

  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix: #xxx[,#xxx], where "xxx" is the issue number)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:
I haven't tested this at all, this is just my naïve attempt to fix this behavior. Please let me know what I've done wrong and I'll correct it. ❤️

Check for Rez in Xcode.app and in command line tools, and error if neither is installed.
@caass caass requested a review from a team August 27, 2020 04:23
@caass
Copy link
Contributor Author

caass commented Aug 27, 2020

There's no pretty error message telling folks to install command line tools for xcode, however I'm pretty sure that the error stack will make it pretty obvious with a single google search what the problem is. There's about a million Medium articles explaining how to run xcode-select --install.

@caass
Copy link
Contributor Author

caass commented Aug 27, 2020

Ok so CI failed, but I'm not sure it was related to my change. Relevant output:

info sharp Downloading https://github.com/lovell/sharp-libvips/releases/download/v8.9.1/libvips-8.9.1-darwin-x64.tar.gz
ERR! sharp connect ETIMEDOUT 52.216.160.155:443
info sharp Attempting to build from source via node-gyp but this may fail due to the above error

I think this is just a network timeout. I've seen some stuff about this being an issue, I wonder if triggering a re-run will fix it.

@jbolda
Copy link
Member

jbolda commented Aug 27, 2020

Could you do something like ${xcode-select --print-path || echo "Can't find Rez at $1, try installing via xcode-select --install"}? You might need to check my bash typing from my phone.

@jbolda
Copy link
Member

jbolda commented Aug 27, 2020

Actually, you could add to the error message here:

print('Failed to find Rez at "%s"!\n' % options.rez)

@caass caass requested a review from a team as a code owner August 28, 2020 00:20
Copy link
Member

@jbolda jbolda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again for your help with this!

@jbolda jbolda merged commit 7a788fd into tauri-apps:dev Aug 28, 2020
@caass caass deleted the patch-1 branch August 28, 2020 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

tauri fails to find Rez when Xcode (the app, not the command line tools) is not installed.
2 participants