Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the ability to navigate with swipe gesture #757

Merged
merged 2 commits into from Nov 16, 2022

Conversation

pan93412
Copy link
Contributor

@pan93412 pan93412 commented Nov 16, 2022

On macOS, add an API to enable or disable backward and forward navigation gestures.

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Docs
  • New Binding issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes, and the changes were approved in issue #___
  • No

Checklist

  • When resolving issues, they are referenced in the PR's title (e.g fix: remove a typo, closes #___, #___)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.
  • I have added a convincing reason for adding this feature, if necessary

Demo video

2022-11-16.7.40.55.mov

Other information

The documentation of this function can be seen on https://developer.apple.com/documentation/webkit/wkwebview/1414995-allowsbackforwardnavigationgestu.

@pan93412 pan93412 marked this pull request as ready for review November 16, 2022 11:36
@pan93412 pan93412 requested a review from a team as a code owner November 16, 2022 11:36
@pan93412 pan93412 changed the title feat(webview): Add allowsBackForwardNavigation Add the ability to navigate with swipe gesture Nov 16, 2022
examples/with_forward_gesture.rs Outdated Show resolved Hide resolved
.changes/allow-back-forward-gesture.md Outdated Show resolved Hide resolved
On macOS, add an API to enable or disable
backward and forward navigation gestures.

For details, see <https://developer.apple.com/documentation/webkit/wkwebview/1414995-allowsbackforwardnavigationgestu>

Signed-off-by: pan93412 <pan93412@gmail.com>
Copy link
Member

@amrbashir amrbashir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@amrbashir amrbashir merged commit 487dff0 into tauri-apps:dev Nov 16, 2022
@github-actions github-actions bot mentioned this pull request Nov 16, 2022
@pan93412 pan93412 deleted the allow-back-forward-gesture branch November 16, 2022 22:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants