Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: change custom protocol handler input to an owned Request #979

Closed
wants to merge 1 commit into from

Conversation

lucasfernog
Copy link
Member

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Docs
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes
  • No

Checklist

  • This PR will resolve #___
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.
  • I have added a convincing reason for adding this feature, if necessary
  • It can be built on all targets and pass CI/CD.

Other information

@lucasfernog lucasfernog requested a review from a team as a code owner June 25, 2023 01:14
@wusyong
Copy link
Member

wusyong commented Jun 25, 2023

Can we take this chance to refactor to Request<Cow<'static, [u8]>>?
This could reduce some vector allocations.

@lucasfernog
Copy link
Member Author

@wusyong I couldn't really see the improvement, the request body will never be an static [u8].

@wusyong
Copy link
Member

wusyong commented Jul 23, 2023

Or could it be Cow<'_, [u8]>? Because I know many of original types can be deref to u8 slice.

@amrbashir
Copy link
Member

Closing since this change has been merged in #1017

@amrbashir amrbashir closed this Sep 6, 2023
@amrbashir amrbashir deleted the refactor/custom-protocol-req branch September 6, 2023 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants