Add support for building & running from within a container #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gdm85
commented
May 22, 2022
| $CONTAINER_RUN build-from-container.sh | ||
|
|
||
| if [ "$S" = "run-from-container.sh" ]; then | ||
| exec $CONTAINER_RUN ./123 "$@" |
There was a problem hiding this comment.
I just realised that the "$@" will actually never work because script requires only 1 argument; I can either remove this feature or make a conditional check for the number of arguments.
gdm85
force-pushed
the
feat/container-build-and-run
branch
2 times, most recently
from
2d0f77e
to
a1ad0d5
Compare
Open
gdm85
force-pushed
the
feat/container-build-and-run
branch
from
bd6ac6e
to
0545cb5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR brings 2 main features:
123from within a container using Docker or Podman123from a containerThe end users simply have to run
./run-from-container.sh 20and they will get within a Lotus 1-2-3 window in a few jiffies (well, assuming that they do not have a large terminal and are also affected by #8); I haven't tested with versions 21 and 22 of Ubuntu but in worst case scenarios some dependencies need to be customized.NOTE: the project directory is mounted as a volume so all build artifacts are retained (same goes for the Lotus 1-2-3 root folder).