-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow searching by foreign name #6
Comments
It definitely shouldn't be default, getting rid of pollution by non-English names was one of the big reasons I wrote mtg.wtf in the first place. As for special fields with query like It's basically a question of treating it as per-card property (and in such case, does it have two names, most recent name only, or how does that work exactly?) or per-printing property (which would be somewhat weird). There's also minor issues:
|
Normalizing everything to ASCII is a bad idea (in some languages, there are minimal pairs where the word means something else without the diacritics). If someone's searching for e.g. the German version of Anger, you'll want to accept both normalized ( |
We could figure out some special case for German umlauts, force normalizing everything is pretty much best strategy for English, but I'm aware it's less great for other languages. I'll probably just add some rudimentary support for queries like |
It's working now (disregarding edge cases) - http://mtg.wtf/help/syntax for some examples |
It would be helpful if searching by name also worked for non-English card names, or if there were a special syntax for this.
The text was updated successfully, but these errors were encountered: