Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

It is better to make the object String thet then to apply an equals m… #169

Merged

Conversation

vedes
Copy link
Contributor

@vedes vedes commented Jul 20, 2017

…ethod

The IrGetCode block uses char as the result, but the string validation methods use either char [] or String. This leads to a type mismatch error in the Arduino source code. It is better to replace the return type in IrGetCode with String.

@TonyCallear
Copy link
Collaborator

The description asks a question "It is better to replace the return type in IrGetCode with String." and I don't know the answer - so unsure whether to merge or not.

@vedes
Copy link
Contributor Author

vedes commented Oct 30, 2017

Welcome back TonyCaller!
I just tried to use the ir_getcode block and got an error when I compiling. I tried different ways to connect this block, but nothing is worked. The problem is that IrGetCode result is char[] however variables blocks in checks is need the String type. So I had to change the IrGetCode method to make the program work. Do you have a better solution to this problem? If yes, tell me please.

@TonyCallear
Copy link
Collaborator

Well, it compiles in Arduino and does not seem to affect anything else - I am not much help after that!
Remember - I don't have the hardware or even much idea of what it's trying to do.

I will merge this later today, unless anyone points out a problem.

@TonyCallear TonyCallear merged commit 70492d9 into taweili:master Nov 12, 2017
@vedes
Copy link
Contributor Author

vedes commented Nov 13, 2017

Thanks TonyCallear!

@imspammers
Copy link

hi :) created an account just to help you as your requested in
https://github.com/taweili/ardublock/releases/tag/beta-20171028

i hope i can be of help testing your TC version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants